Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TopFrame function #10

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Add TopFrame function #10

merged 2 commits into from
Jan 9, 2024

Conversation

kazukousen
Copy link
Contributor

Support to add TopFrame function

winebarrel
winebarrel approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@winebarrel winebarrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kazukousen
Copy link
Contributor Author

@winebarrel

PTAL 🙇 88cf9b3

@kazukousen kazukousen force-pushed the top_frame branch 2 times, most recently from c8a1d47 to c639cea Compare January 9, 2024 07:04
@kazukousen
Copy link
Contributor Author

kazukousen commented Jan 9, 2024 •
edited
Loading

@winebarrel PTAL again 🙇 0073343

winebarrel
winebarrel approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@winebarrel winebarrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kazukousen kazukousen merged commit 70994c6 into main Jan 9, 2024
2 checks passed
@kazukousen kazukousen deleted the top_frame branch January 9, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winebarrel winebarrel winebarrel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazukousen @winebarrel